Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 10, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the documentation for getting started with the thirdweb package in a React Native environment, including troubleshooting steps and commands for building and running the app on iOS and Android.

Detailed summary

  • Updated page.mdx to include prebuild and run commands for iOS and Android.
  • Added a new Troubleshooting section in page.mdx with common issues and solutions.
  • Modified useSwapSupportedChains.ts to conditionally append query parameters.
  • Expanded the sidebar.tsx to include a link to the new Troubleshooting section.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 10:44pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 10:44pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 10:44pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 10:44pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: 7b5d421

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added Portal Involves changes to the Portal (docs) codebase. packages labels Oct 10, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.07 KB (0%) 842 ms (0%) 2.7 s (-25.51% 🔽) 3.6 s
thirdweb (cjs) 101.87 KB (0%) 2.1 s (0%) 5.1 s (-21.07% 🔽) 7.1 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 199 ms (-24.39% 🔽) 296 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 56 ms (+32.87% 🔺) 66 ms
thirdweb/react (minimal + tree-shaking) 17.24 KB (0%) 345 ms (0%) 713 ms (+93.85% 🔺) 1.1 s

@joaquim-verges joaquim-verges marked this pull request as ready for review October 10, 2024 22:37
const fetchWithHeaders = getClientFetch(client);
const res = await fetchWithHeaders(
`${getPaySupportedDestinations()}?isTestMode=${isTestMode}`,
`${getPaySupportedDestinations()}${isTestMode ? "?isTestMode=true" : ""}`,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sneaked this one in - we were sending isTestMode=undefined

@codecov
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.76%. Comparing base (ccd4cd6) to head (7b5d421).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...tWallet/screens/Buy/swap/useSwapSupportedChains.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4990      +/-   ##
==========================================
+ Coverage   47.68%   47.76%   +0.07%     
==========================================
  Files        1058     1058              
  Lines       57290    57290              
  Branches     3941     3945       +4     
==========================================
+ Hits        27320    27364      +44     
+ Misses      29279    29235      -44     
  Partials      691      691              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ccd4cd6
packages 43.56% <0.00%> (+0.09%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...tWallet/screens/Buy/swap/useSwapSupportedChains.ts 10.44% <0.00%> (ø)

... and 3 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit 982219a into main Oct 11, 2024
30 of 31 checks passed
@joaquim-verges joaquim-verges deleted the feat_add_troubleshooting_guide_for_React_Native branch October 11, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants